cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <>
Subject [GitHub] cordova-browser pull request #32: Cb 12804
Date Wed, 14 Jun 2017 23:32:44 GMT
GitHub user purplecabbage opened a pull request:

    Cb 12804

    ### Platforms affected
    ### What does this PR do?
    adds manifest.json support
    ### What testing has been done on this change?
    added tests
    This pr includes all commits from #30 which can be closed.
    ### Checklist
    - [x] [Reported an issue]( in the JIRA
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull CB-12804

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #32
commit eec8c5398440f6fcbbd4e5c1178c46c3d12df688
Author: Audrey So <>
Date:   2017-05-26T16:38:09Z

    CB-12804 : manifest.json added to browser during create

commit 4a52f045e4beb0d991db613937061757df9638f9
Author: Jesse MacFadyen <>
Date:   2017-06-01T20:21:32Z

    work in progress

commit b85f06ba6a17f8cbd551ef5f827e24384084a72f
Author: Jesse MacFadyen <>
Date:   2017-06-02T18:50:58Z

    Updated images to improve lighthouse score. Added orientation to manifest.

commit 3052805af944a38fa54926393d4f49e49c8cae11
Author: Jesse MacFadyen <>
Date:   2017-06-04T06:51:49Z

    add link rel=manifest, more manifest specs to check

commit 012191c3011076f995f4ec2af8f8729d153fd4e7
Author: Jesse MacFadyen <>
Date:   2017-06-04T07:00:04Z

    remove console.log to stop whining CI

commit 146fb74b69e0c24e56ecff38f0e38aad8353e9fd
Author: Jesse MacFadyen <>
Date:   2017-06-06T18:47:08Z

    remove old xhr-activex windows bs, update to use pagevisibility instead of webkitpagevisibility

commit 5b837270c26d0ee8856ebbf018f516f5998136c9
Author: Jesse MacFadyen <>
Date:   2017-06-07T22:55:11Z

    output create events, copy manifest.json from template to platform_www

commit c4511806452014fd99f5cce6f5ce73614402063a
Author: Jesse MacFadyen <>
Date:   2017-06-09T18:54:09Z

    clean up some cruft, create emit errors, removed old ActiveX seeking xhr code

commit 2e63f9fe43d0e927f9d2ab9cfc2aedd1c2f74f36
Author: Jesse MacFadyen <>
Date:   2017-06-14T23:23:58Z

    run gets start_url from manifest, spec verifies manifest, Api delays writing to manifest
and uses platform_www/


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message