cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rafael-chavez <...@git.apache.org>
Subject [GitHub] cordova-ios pull request #317: Add logging for malformed data
Date Fri, 02 Jun 2017 23:30:04 GMT
GitHub user rafael-chavez opened a pull request:

    https://github.com/apache/cordova-ios/pull/317

    Add logging for malformed data

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    iOS
    
    ### What does this PR do?
    
    Prints the malformed data created by the process for further debugging.
    
    ### What testing has been done on this change?
    
    Hard to reproduce, but sometimes the evaulateJavascript method on WKWebView creates a
malformed JSON string. 
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rafael-chavez/cordova-ios master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/317.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #317
    
----
commit e0a5c0e0bb71f582be8f30e08e23a06b09d00b08
Author: rafael-chavez <rafchavez3@gmail.com>
Date:   2017-06-02T23:28:01Z

    Add logging for malformed data

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message