cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paymicro <...@git.apache.org>
Subject [GitHub] cordova-browser pull request #31: CB-12905: (linux) Fix issue with freezing ...
Date Fri, 09 Jun 2017 13:59:53 GMT
GitHub user paymicro opened a pull request:

    https://github.com/apache/cordova-browser/pull/31

    CB-12905: (linux) Fix issue with freezing after launching the browser

    In Linux, the callback is not called until the process terminates.
    If the error is not caused within 2 seconds, then the promise will be resolved.
    
    ### Platforms affected
    - Linux
    
    ### What does this PR do?
    - If the [error after launching the browser](https://github.com/Microsoft/cordova-simulate/issues/245)
is not caused within 2 seconds, then the promise will be resolved. 
    
    ### What testing has been done on this change?
    - manual testing launching browsers in Linux, Windows and MacOs
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paymicro/cordova-browser Bugs/bug446896-simulate-in-linux

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-browser/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #31
    
----
commit 17ca6c585afab25b68e868ecc0a13e55e803dc40
Author: Pavel Yakovlev (Akvelon) <v-payako@microsoft.com>
Date:   2017-06-09T13:13:19Z

    In Linux, the callback is not called until the process terminates.
    If the error is not caused within 2 seconds, then the promise will be resolved.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message