cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From charlesverge <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request #268: CB-12873: Add customization options...
Date Thu, 01 Jun 2017 05:42:24 GMT
GitHub user charlesverge opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/268

    CB-12873: Add customization options for caputre button, resizing of v…

    …ideo browser resize
    
    Reported issue https://issues.apache.org/jira/browse/CB-12873
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    browser platform
    
    ### What does this PR do?
    
    
    
    The browser version of the camera plugin is missing
    
        Adds options to configure
            class name for div which holds video preview
            Option to disable audio
        Adds Cancel button
        Resizing of video upon browser resize or orientation change
        Graceful activation of file selector dialog and visibility of file input
    
    ### What testing has been done on this change?
    
    Tested on chrome and firefox
    
    ### Checklist
    - [x ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/charlesverge/cordova-plugin-camera CB-12873cordova-plugin-camera

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/268.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #268
    
----
commit 4c09f37c680fa6bb076ed526766145a53fc0d10a
Author: Charles Verge <charles.verge@is.ca>
Date:   2017-05-31T23:32:09Z

    CB-12873: (browser) Add customization options for caputre button, resizing of video browser
resize

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message