cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertfromont <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request #210: CB-12961
Date Tue, 27 Jun 2017 22:33:02 GMT
GitHub user robertfromont opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/210

    CB-12961

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    browser (on iOS only)
    
    ### What does this PR do?
    
    Works around the fact that Safari on iOS doesn't support saving Blobs in indexedDB databases
    
    ### What testing has been done on this change?
    
    Manual testing on the browser platform to ensure that
     - it now works on iOS browsers
     - it still works on Firefox and Chrome browsers
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    (sorry, unsure how I'd write an automated test for iOS browsers)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nzilbb/cordova-plugin-file CB-12961

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/210.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #210
    
----
commit 79ccf5470a6ab99a4037c91d10106247afa2005c
Author: Robert Fromont <robert@fromont.net.nz>
Date:   2017-06-27T21:31:09Z

    Get file plugin working on browser platform for iOS devices.
    
    Safari on iOS doesn't support saving Blobs or objects with function attributes to indexedDB
databases.
    These changes ensure that MyFile objects don't have a Blob attribute, and don't have function
attributes.

commit a071548707ddad6a7d90b425f25263485b2a419d
Author: Robert Fromont <robert@fromont.net.nz>
Date:   2017-06-27T21:51:51Z

    Revert "Get file plugin working on browser platform for iOS devices."
    
    This reverts commit 79ccf5470a6ab99a4037c91d10106247afa2005c.

commit 6e7640ee702a074ae8aaadb36d9b918dc8a5f9d3
Author: Robert Fromont <robert@fromont.net.nz>
Date:   2017-06-27T22:24:02Z

    CB-12961 browser on iOS - Get "put" working on browser platform for iOS devices.
    
    Safari (and Chrome) on iOS doesn't support saving Blobs or objects with function attributes
to indexedDB databases.
    These changes ensure that MyFile objects don't have a Blob attribute, and don't have function
attributes.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message