cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adriano-di-giovanni <...@git.apache.org>
Subject [GitHub] cordova-plugin-media pull request #143: CB-7684
Date Thu, 22 Jun 2017 09:36:43 GMT
GitHub user adriano-di-giovanni opened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/143

    CB-7684

    ### Platforms affected
    
    iOS
    
    ### What does this PR do?
    
    This PR will add an `isPlayingOrRecording` method that's called before any try to deactivate
the AVSession.
    
    ### What testing has been done on this change?
    
    This has been tested on 11 apps that are going to updated live.
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/adriano-di-giovanni/cordova-plugin-media CB-7684_cordova-plugin-media

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/143.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #143
    
----
commit 0799d12a2c16d341f2e615fb0ca6b4dd1ab1bb1b
Author: Adriano Di Giovanni <me@adrianodigiovanni.com>
Date:   2017-06-21T10:45:01Z

    do not deactivate avsession when items finish playing

commit d17c6a2dde8e8bb0e6c53d91283fce9dd8002306
Author: Adriano Di Giovanni <me@adrianodigiovanni.com>
Date:   2017-06-22T09:20:19Z

    CB76-84: check if any audio file is playing or recording before deactivating the avsession

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message