cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jab <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request #128: Fix CB-12947 (incorrect docum...
Date Fri, 23 Jun 2017 15:41:57 GMT
GitHub user jab opened a pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/128

    Fix CB-12947 (incorrect documentation of iPhone 5 and 5s resolution)

    iPhone 5, 5s, and SE have resolution 640x1136, not 640x960 as currently documented.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jab/cordova-plugin-splashscreen patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-splashscreen/pull/128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #128
    
----
commit c81df6f274d08f3214ba8a692f74741fa0cfe1a1
Author: jab <jab@users.noreply.github.com>
Date:   2017-06-23T15:39:29Z

    CB-12947: (docs) Fix iPhone 5 and 5s resolution
    
    (and add iPhone SE which was missing)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message