cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kerrisho...@gmail.com
Subject Re: cordova-lib proposal on test directory reorganization
Date Tue, 27 Jun 2017 21:16:22 GMT
Everything looked good from my once over -- thanks for the work you're putting in to this!

Sent from my phone. 

___________________________________
Kerri 

> On Jun 27, 2017, at 12:44, Filip Maj <maj.fil@gmail.com> wrote:
> 
> I'm planning on merging this in later today if there are no more
> comments. So far only positive ones!
> 
>> On Mon, Jun 26, 2017 at 7:45 AM, Filip Maj <maj.fil@gmail.com> wrote:
>> Still looking for a bit more feedback, please take a look if you have
>> time! Thanks Anis for your feedback :)
>> 
>> Don't worry about the diff / changeset (~1900 files changed!), the PR
>> description, I think, summarizes the changes well enough. Almost all
>> the changes are renaming files and tweaking the directory structure.
>> 
>> I am thinking of merging this in Wednesday if I get no more comments,
>> or possibly sooner if I get nothing but positive feedback. They are
>> big directory structure changes, and the sooner we can get this in,
>> the less rebase headache will exist.
>> 
>> Thanks!
>> Fil
>> 
>>> On Thu, Jun 22, 2017 at 5:41 PM, Filip Maj <maj.fil@gmail.com> wrote:
>>> Proposal up in PR form here: https://github.com/apache/cordova-lib/pull/568
>>> 
>>> tl;dr consolidating `spec-cordova/` and `spec-plugman` directories
>>> into one, setting up to for one-unit-test-spec.js per source-module.js
>>> file.
>>> 
>>> Looking for eyes and feedback! If you have any, please drop comments in the PR.
>>> 
>>> Thanks!
>>> Fil
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message