cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shazron <shaz...@gmail.com>
Subject Re: Incompatible plugin should reject the build
Date Fri, 02 Jun 2017 17:15:35 GMT
Consensus on this long stewing issue of 7 months?

If you deleted the thread:
1. Issue https://issues.apache.org/jira/browse/CB-12122
2. Thread https://s.apache.org/ofqR

+1 on engine check failing the build.
Questions that need answered: Does cordova-fetch on cordova@7 do this
already, like Simon said?


On Mon, Nov 7, 2016 at 6:34 PM, Simon MacDonald <simon.macdonald@gmail.com>
wrote:

> I think an engine check should fail the build. If there plugin version
> they are trying to use will not work with the version of cordova or
> platform they are currently using in their project it should not
> build. Folks can screw up their semver in config.xml and end up
> pulling in a plugin version that doesn't work with the CLI they are
> currently using so stuff will just be horribly broken without them
> knowing.
>
> Also, I thought the new cordova-fetch was supposed to prevent this
> sort of thing?
> Simon Mac Donald
> http://simonmacdonald.com
>
>
> On Mon, Nov 7, 2016 at 8:24 PM, Shazron <shazron@gmail.com> wrote:
> > See https://issues.apache.org/jira/browse/CB-12122
> >
> > Right now if a plugin fails an <engines> check, it just warns. Should we
> > make engine checks fail the build?
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message