cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json
Date Tue, 27 Jun 2017 01:13:39 GMT
Github user purplecabbage commented on a diff in the pull request:

    https://github.com/apache/cordova-browser/pull/32#discussion_r124158333
  
    --- Diff: bin/template/cordova/Api.js ---
    @@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {
             "locations":this.locations,
             "root": this.root,
             "name": this.platform,
    -        "version": { "version" : "1.0.0" },
    +        "version": { "version" : "1.0.0" }, // um, todo!
             "projectConfig": this.config
         };
     };
     
     Api.prototype.prepare = function (cordovaProject,options) {
     
         // First cleanup current config and merge project's one into own
    -    var defaultConfig = path.join(this.locations.platformRootDir,'cordova',
    +    var defaultConfigPath = path.join(this.locations.platformRootDir,'cordova',
                             'defaults.xml');
    -
    -    var ownConfig = this.locations.configXml;
    -
    +    var ownConfigPath = this.locations.configXml;
         var sourceCfg = cordovaProject.projectConfig;
    +
         // If defaults.xml is present, overwrite platform config.xml with it.
         // Otherwise save whatever is there as defaults so it can be
         // restored or copy project config into platform if none exists.
    -    if (fs.existsSync(defaultConfig)) {
    +    if (fs.existsSync(defaultConfigPath)) {
             this.events.emit('verbose', 'Generating config.xml from defaults for platform
"' + this.platform + '"');
    -        shell.cp('-f', defaultConfig, ownConfig);
    -    } else if (fs.existsSync(ownConfig)) {
    -        shell.cp('-f', ownConfig, defaultConfig);
    -    } else {
    -        shell.cp('-f', sourceCfg.path, ownConfig);
    +        shell.cp('-f', defaultConfigPath, ownConfigPath);
    +    }
    +    else if (fs.existsSync(ownConfigPath)) {
    +        this.events.emit('verbose', 'Generating defaults.xml from own config.xml for
platform "' + this.platform + '"');
    +        shell.cp('-f', ownConfigPath, defaultConfigPath);
    +    }
    +    else {
    +        this.events.emit('verbose', 'case 3"' + this.platform + '"');
    +        shell.cp('-f', sourceCfg.path, ownConfigPath);
         }
     
    -    // this._munger.reapply_global_munge().save_all();
    -
    -    this.config = new ConfigParser(ownConfig);
    +    // merge our configs
    +    this.config = new ConfigParser(ownConfigPath);
         xmlHelpers.mergeXml(cordovaProject.projectConfig.doc.getroot(),
    -        this.config.doc.getroot(), this.platform, true);
    +                        this.config.doc.getroot(),
    +                        this.platform, true);
         this.config.write();
     
    -    /*
    -        "browser": {
    -        "parser_file": "../cordova/metadata/browser_parser",
    -        "handler_file": "../plugman/platforms/browser",
    -        "url": "https://git-wip-us.apache.org/repos/asf?p=cordova-browser.git",
    -        "version": "~4.1.0",
    -        "deprecated": false
    -    }
    -    */
    -
         // Update own www dir with project's www assets and plugins' assets and js-files
         this.parser.update_www(cordovaProject.locations.www);
     
    +    // Copy or Create manifest.json
    +    // todo: move this to a manifest helper module
    +    // output path
    +    var manifestPath = path.join(this.locations.www,'manifest.json');
    +    var srcManifestPath =path.join(cordovaProject.locations.www,'manifest.json');
    +    if(fs.existsSync(srcManifestPath)) {
    +        // just blindly copy it to our output/www
    +        // todo: validate it? ensure all properties we expect exist?
    +        this.events.emit('verbose','copying ' + srcManifestPath + ' => ' + manifestPath);
    +        shell.cp('-f',srcManifestPath,manifestPath);
    +    }
    +    else {
    +        var manifestJson = {
    +            "background_color": "#000",
    --- End diff --
    
    Changed to white in #36


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message