cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From infil00p <...@git.apache.org>
Subject [GitHub] cordova-android pull request #384: CB-11244: Studio project cleanup
Date Fri, 23 Jun 2017 21:06:35 GMT
Github user infil00p commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/384#discussion_r123844605
  
    --- Diff: bin/lib/create.js ---
    @@ -125,16 +131,24 @@ function writeProjectProperties(projectPath, target_api) {
         fs.writeFileSync(dstPath, data);
     }
     
    -function prepBuildFiles(projectPath) {
    +// This makes no sense, what if you're building with a different build system?
    --- End diff --
    
    We're already doing that in the next two lines? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message