cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From filmaj <...@git.apache.org>
Subject [GitHub] cordova-android pull request #384: CB-11244: Studio project cleanup
Date Fri, 23 Jun 2017 20:09:44 GMT
Github user filmaj commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/384#discussion_r123834608
  
    --- Diff: bin/lib/create.js ---
    @@ -314,7 +340,18 @@ exports.update = function(projectPath, options, events) {
         return Q()
         .then(function() {
     
    -        var manifest = new AndroidManifest(path.join(projectPath, 'AndroidManifest.xml'));
    +        var isAndroidStudio = AndroidStudio.isAndroidStudioProject(projectPath);
    +        var isLegacy = !isAndroidStudio;
    +        var manifest = null;
    +        var builder = 'gradle';
    +
    +        if(isAndroidStudio) {
    +          manifest = new AndroidManifest(path.join(projectPath, 'app', 'main', 'AndroidManifest.xml'));
    +          builder = 'studio';
    +        } else {
    +          manifest = new AndroidManifest(path.join(projectPath, 'AndroidManifest.xml'));
    +          builder = 'gradle';
    +        }
    --- End diff --
    
    Same thing here, this may be better folded up into the Builders?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message