cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From filmaj <...@git.apache.org>
Subject [GitHub] cordova-lib issue #561: Cb 12870 - Check that all use cases are caught in Ap...
Date Fri, 23 Jun 2017 17:02:15 GMT
Github user filmaj commented on the issue:

    https://github.com/apache/cordova-lib/pull/561
  
    Your experience going through the integration tests in here is valuable with respect to
understanding what code these tests exercise, so armed with that knowledge, I think you have
the right context to add unit tests for that code (and instead, delete the integration tests
relevant to that code).
    
    As for whether it's in this PR or a separate one, your call. There will probably end up
being extraneous commits in this PR. I would probably issue a new PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message