cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #566: Refactor Plugin Command, test improvements, p...
Date Wed, 21 Jun 2017 21:05:38 GMT
Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/566#discussion_r123359407
  
    --- Diff: src/cordova/plugin_parser.js ---
    @@ -18,12 +18,14 @@
     */
     
     var xml = require('cordova-common').xmlHelpers;
    +var events = require('cordova-common').events;
     
     /** Deprecated. Use PluginInfo instead. */
    -function plugin_parser(xmlPath) {
    +function plugin_parser (xmlPath) {
    +    events.emit('warn', 'WARNING: Cordova\'s plugin_parser class is now deprecated and
will be removed in a future version. Please transition to using the PluginInfo class instead.');
    --- End diff --
    
    Good call on deprecation warning


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message