cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pbudzinsky <...@git.apache.org>
Subject [GitHub] cordova-ios pull request #321: CB-12937 - (iOS) added new method handleOpenU...
Date Wed, 21 Jun 2017 13:49:05 GMT
Github user pbudzinsky commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/321#discussion_r123253143
  
    --- Diff: CordovaLib/Classes/Public/CDVAppDelegate.m ---
    @@ -79,8 +79,16 @@ - (BOOL)application:(UIApplication*)application openURL:(NSURL*)url
sourceApplic
             return NO;
         }
     
    +    NSDictionary *openURLData = @{
    +            @"url": url,
    +            @"sourceApplication": sourceApplication,
    +            @"annotation": annotation
    --- End diff --
    
    `annotation` could be `nil` here leading to unhandled exception resulting in a crash


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message