cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Giorgioshooter <...@git.apache.org>
Subject [GitHub] cordova-ios pull request #321: CB-12937 - (iOS) added new method handleOpenU...
Date Tue, 20 Jun 2017 19:54:21 GMT
Github user Giorgioshooter commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/321#discussion_r123078350
  
    --- Diff: CordovaLib/Classes/Public/CDVAppDelegate.m ---
    @@ -78,9 +78,23 @@ - (BOOL)application:(UIApplication*)application openURL:(NSURL*)url
sourceApplic
         if (!url) {
             return NO;
         }
    +    
    +    NSMutableDictionary * openURLData = [[NSMutableDictionary alloc] init];
    +    
    +    [openURLData setValue:url forKey:@"url"];
    +    
    +    if (sourceApplication) {
    +        [openURLData setValue:sourceApplication forKey:@"sourceApplication"];
    +    }
    +    
    +    if (annotation) {
    +        [openURLData setValue:annotation forKey:@"annotation"];
    +    }
     
    --- End diff --
    
    Yeah I was between this or adding the fields if they exist. I will change it to NSDictionary
with literal.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message