cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From filmaj <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #562: Removing lazy load, platform command refactor...
Date Thu, 15 Jun 2017 14:51:03 GMT
Github user filmaj commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/562#discussion_r122223046
  
    --- Diff: src/cordova/platform.js ---
    @@ -1,769 +0,0 @@
    -/**
    --- End diff --
    
    Sure do! Basically, each module should have unit tests. A good rule of thumb is to have
one spec file per module file.
    
    To really get a sense of what coverage exists and what is missing, run `npm run cover`
and get the code coverage report. Note that as of right now, the unit tests still have _some_
integration tests - so the code coverage report from a unit test standpoint is somewhat inaccurate
(integration or end to end tests are very coarse, so they probably cover a lot of code unintentionally).
I would recommend a) looking through the spec-cordova and spec-plugman tests for heavy i/o,
very broad tests that we can classify as integration tests and moving them into integration-tests
and b) replacing them with finer-grained unit tests.
    
    This cordova-ios PR is an example of that general pattern: https://github.com/apache/cordova-ios/pull/319


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message