cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <>
Subject [GitHub] cordova-lib pull request #562: Removing lazy load, platform command refactor...
Date Thu, 15 Jun 2017 01:16:15 GMT
Github user stevengill commented on a diff in the pull request:
    --- Diff: src/cordova/platform.js ---
    @@ -1,769 +0,0 @@
    --- End diff --
    to confirm, you ripped out this file into multpile smaller files. I like it. It has been
replaced by addHelper.js, check.js, getPlatformDetailsFromDir.js, index.js, list.js, remove.js
and save.js
    I see tests for addHelper. Do the other modules need new unit tests?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message