cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From filmaj <>
Subject [GitHub] cordova-mobile-spec pull request #144: Use path.sep instead of Unix separato...
Date Wed, 14 Jun 2017 21:43:21 GMT
Github user filmaj commented on a diff in the pull request:
    --- Diff: createmobilespec/createmobilespec.js ---
    @@ -365,7 +365,7 @@ shelljs.config.fatal = true;
     if (argv.clearnpmcache) {
         // clean out cached platforms and plugins and app-hello-world
         var home_dir = process.env.HOME || process.env.HOMEPATH || process.env.USERPROFILE;
    -    shelljs.rm("-rf", path.join(home_dir, ".cordova/npm_cache"));
    +    shelljs.rm("-rf", path.join(home_dir, ".cordova" + path.sep + "npm_cache"));
    --- End diff --
    you can just use provide ".cordova" and "npm_cache" as separate arguments to `path.join`
here - `join` will handle using the proper separator. 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message