cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From steinwelberg <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #99: inAppBrowser custom applicatio...
Date Fri, 09 Jun 2017 08:12:24 GMT
Github user steinwelberg commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/99#discussion_r121070906
  
    --- Diff: src/ios/CDVInAppBrowser.m ---
    @@ -783,6 +793,16 @@ - (void)showToolBar:(BOOL)show : (NSString *) toolbarPosition
     
     - (void)viewDidLoad
     {
    +    CGRect frame = [UIApplication sharedApplication].statusBarFrame;
    +    UIToolbar* bgToolbar = [[UIToolbar alloc] initWithFrame:frame];
    +    bgToolbar.barStyle = UIBarStyleDefault;
    +    bgToolbar.tintColor = [UIColor whiteColor];
    +    bgToolbar.barTintColor = [UIColor whiteColor];
    +//    [[UIBarItem appearance] setTitleTextAttributes:@{UITextAttributeTextColor : [UIColor
whiteColor]}];
    +
    +
    +    [self.view addSubview:bgToolbar];
    +    
    --- End diff --
    
    I honestly don't know. That's why I mentioned that this merge request somehow contains
more stuff and I'm happy to create a 'clean' merge request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message