cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stalniy <...@git.apache.org>
Subject [GitHub] cordova-plugin-media-capture pull request #79: CB-12882: (ios): adds support...
Date Wed, 07 Jun 2017 04:54:58 GMT
Github user stalniy commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-media-capture/pull/79#discussion_r120534419
  
    --- Diff: src/ios/CDVCapture.m ---
    @@ -292,6 +295,65 @@ - (CDVPluginResult*)processVideo:(NSString*)moviePath forCallbackId:(NSString*)c
         return [CDVPluginResult resultWithStatus:CDVCommandStatus_OK messageAsArray:fileArray];
     }
     
    +- (void)showAlertIfAccessProhibeted
    +{
    +    if (![self hasCameraAccess]) {
    +        [self showPermissionsAlert];
    +    }
    +}
    +
    +- (BOOL)hasCameraAccess
    +{
    +    if (![AVCaptureDevice respondsToSelector:@selector(authorizationStatusForMediaType:)])
{
    +        return YES;
    +    }
    --- End diff --
    
    I'm ok with that. Actually all iOS <= 10.0 currently are not available for installation
on phones. So, it makes sense. 
    Initially I tried to keep support line the same as `cordova-plugin-camera` does.
    
    So, just to double check: 
    1. I remove all `#pragma` statements
    2. I remove all `&UIApplicationOpenSettingsURLString != NULL` checks
    3. I add `ios` version restriction to be iOS 8+


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message