Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: infil00p <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-375-cordova-android@git.apache.org>
In-Reply-To: <git-pr-375-cordova-android@git.apache.org>
Subject: [GitHub] cordova-android pull request #375: CB-12657 android: fixed android 4.3 exit ...
Content-Type: text/plain
Message-Id: <20170501174834.D46AAE0885@git1-us-west.apache.org>
Date: Mon,  1 May 2017 17:48:34 +0000 (UTC)
archived-at: Mon, 01 May 2017 17:48:37 -0000

Github user infil00p commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/375#discussion_r114163718
  
    --- Diff: framework/src/org/apache/cordova/engine/SystemWebViewEngine.java ---
    @@ -326,6 +329,12 @@ public void setPaused(boolean value) {
         @Override
         public void destroy() {
             webView.chromeClient.destroyLastDialog();
    +        nativeToJsMessageQueue.reset();
    --- End diff --
    
    Why are we resetting the nativeToJsMessageQueue on destroy?  We may want to send some events before we kill the WebView.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org