cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From remcohaszing <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #558: CB-12766 Consistently write JSON with 2 space...
Date Tue, 16 May 2017 08:04:28 GMT
GitHub user remcohaszing opened a pull request:

    https://github.com/apache/cordova-lib/pull/558

    CB-12766 Consistently write JSON with 2 spaces indentation

    ### Platforms affected
    None really.
    
    ### What does this PR do?
    JSON was written with 4 spaces indentation and even a tab at some
    point. Most NodeJS tools write their JSON configuration with an
    indentation of 2 spaces. Most notably npm does this, which writes to
    package.json, as does Cordova. This caused unnecessary changes in
    package.json.
    
    ### What testing has been done on this change?
    None, this is mostly stylistic.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/remcohaszing/cordova-lib master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/558.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #558
    
----
commit 7431e36fee775f0383ad3c3dae396a2a95c4bc05
Author: Remco Haszing <remcohaszing@gmail.com>
Date:   2017-05-16T07:58:54Z

    CB-12766 Consistently write JSON with 2 spaces indentation
    
    JSON was written with 4 spaces indentation and even a tab at some
    point. Most NodeJS tools write their JSON configuration with an
    indentation of 2 spaces. Most notably npm does this, which writes to
    package.json, as does Cordova. This caused unnecessary changes in
    package.json.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message