cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kevin-lot <...@git.apache.org>
Subject [GitHub] cordova-android pull request #379: CB-12802: (android) When multiple APKs bu...
Date Thu, 11 May 2017 18:08:01 GMT
GitHub user kevin-lot opened a pull request:

    https://github.com/apache/cordova-android/pull/379

    CB-12802: (android) When multiple APKs build is enable, you cannot sign and the build
crashes.

    When 'cdvBuildMultipleApks' is true, 'task.name' can have 'validateSigningArmv7Release'
or 'validateSigningX86Release' values.
    
    ### Platforms affected
    cordova 7
    cordova-android 6.2.3
    
    ### What does this PR do?
    Fix build.gradle to sign when multiple APK is enable.
    
    ### What testing has been done on this change?
    Test to build with or without signature and with or without multiple APK.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Keyclic/cordova-android 6.2.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/379.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #379
    
----
commit b57ee1afa10b4cfba8858742d43404fab536d0e0
Author: Kevin Lot <kevin-lot@users.noreply.github.com>
Date:   2017-05-11T17:58:29Z

    Include missing values for task.name
    
    When 'cdvBuildMultipleApks' is true, 'task.name' can have 'validateSigningArmv7Release'
or 'validateSigningX86Release' values.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message