cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From MeirBon <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #221: CB-12834: (android) Fix bug w...
Date Fri, 19 May 2017 09:51:51 GMT
GitHub user MeirBon opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/221

    CB-12834: (android) Fix bug when opening a download link

    ### Platforms affected
    Android
    
    ### What does this PR do?
    It adds a dialog to request permissions when a file is downloaded in the inappbrowser.
I have committed the changes using the given format, original changes are from [this pull
request](https://github.com/apache/cordova-plugin-inappbrowser/pull/201)
    
    ### What testing has been done on this change?
    Multiple Android devices have been tested. Different download links, cancelling the download
then re-downloading.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MeirBon/cordova-plugin-inappbrowser download-permissions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/221.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #221
    
----
commit d246092d1a066160aa4f3a4e5424b255d1550076
Author: Mèir Noordermeer <m.noordermeer@genkgo.nl>
Date:   2017-05-19T09:26:29Z

    CB-12834: (android) Fix bug when opening a download link

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message