cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From brodybits <...@git.apache.org>
Subject [GitHub] cordova-app-hello-world pull request #19: CB-12397 fix .gitignore for plugin...
Date Wed, 10 May 2017 21:46:15 GMT
GitHub user brodybits opened a pull request:

    https://github.com/apache/cordova-app-hello-world/pull/19

    CB-12397 fix .gitignore for plugins & platforms

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    All
    
    ### What does this PR do?
    
    Add `plugins` and `platforms` to `.gitignore` to resolve [Apache Cordova CB-12397](https://issues.apache.org/jira/browse/CB-12397),
now working if properly integrated with apache/cordova-create#8 (workaround solution to [Apache
Cordova CB-12397](https://issues.apache.org/jira/browse/CB-12397) in `cordova-create`).
    
    ### What testing has been done on this change?
    
    As described in <https://github.com/apache/cordova-create/pull/8>: tested using
local installation of <https://github.com/brodybits/cordova-cli/tree/cb-12397-devtest1>.
    
    ### Checklist
    
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    
    **NOT RELEVANT in this PR:**
    - ~~Added automated test coverage as appropriate for this change.~~

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brodybits/cordova-app-hello-world cb-12397

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-app-hello-world/pull/19.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19
    
----
commit f7c85137256e050856e8fe9341ed3b2ba0c319f1
Author: Christopher J. Brody <brodybits@litehelpers.net>
Date:   2017-05-09T13:11:49Z

    CB-12397 fix .gitignore for plugins & platforms

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message