cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amovsesy <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request #179: Fixing a security issue whic...
Date Fri, 12 May 2017 18:57:16 GMT
GitHub user amovsesy opened a pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/179

    Fixing a security issue which is banned by google play that can be fo…

    …und https://support.google.com/faqs/answer/6346016
    
    Adding a check for the certificate that comes in when connecting to the server
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Android
    
    ### What does this PR do?
    Adds a check for the connection that gets created
    
    ### What testing has been done on this change?
    Ran the tests
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rentlyio/cordova-plugin-file-transfer fixingSecurityIssue

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file-transfer/pull/179.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #179
    
----
commit 0503664bd14319414630b7c704310b8c49c142d6
Author: Aleksandr Movsesyan <amovsesy@users.noreply.github.com>
Date:   2017-05-12T18:29:39Z

    Fixing a security issue which is banned by google play that can be found https://support.google.com/faqs/answer/6346016
    Adding a check for the certificate that comes in when connecting to the server

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message