cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From macdonst <...@git.apache.org>
Subject [GitHub] cordova-browser pull request #30: CB-12804 : manifest.json added to browser ...
Date Mon, 29 May 2017 14:10:00 GMT
Github user macdonst commented on a diff in the pull request:

    https://github.com/apache/cordova-browser/pull/30#discussion_r118941014
  
    --- Diff: bin/template/cordova/Api.js ---
    @@ -96,6 +96,40 @@ Api.createPlatform = function (dest, config, options, events) {
             events.emit('error','createPlatform is not callable from the browser project
API.');
             throw(e);
         }
    +    
    +    // Create manifest.json
    +    var manifestJson;
    +    var manifestJsonPath = path.join(dest,'manifest.json');
    +
    +    // Check if path exists and require manifestJsonPath.
    +    if(fs.existsSync(manifestJsonPath)) {
    +        try {
    +            manifestJson = require(manifestJsonPath);
    +        } 
    +        catch (e) {
    +            console.log("error : " + e);
    +            events.emit('error', 'unable to require manifest.json path.');
    +        }
    +    } else if (manifestJson === undefined) {
    +        manifestJson = {};
    +        if(config){
    +            if(config.name()) {
    +                manifestJson.name = config.name();
    +            }
    --- End diff --
    
    We should add short name as well.
    
    ```
    manifestJson.short_name = config.shortName();
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message