cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sruthakeerthikotla <...@git.apache.org>
Subject [GitHub] cordova-node-xcode pull request #2: CB-12844 Update pbxProject.js
Date Fri, 26 May 2017 12:55:46 GMT
Github user sruthakeerthikotla commented on a diff in the pull request:

    https://github.com/apache/cordova-node-xcode/pull/2#discussion_r118695621
  
    --- Diff: lib/pbxProject.js ---
    @@ -1546,7 +1546,7 @@ function pbxShellScriptBuildPhaseObj(obj, options, phaseName) {
         obj.inputPaths = options.inputPaths || [];
         obj.outputPaths = options.outputPaths || [];
         obj.shellPath = options.shellPath;
    -    obj.shellScript = '"' + options.shellScript.replace(/"/g, '\\"') + '"';
    +    obj.shellScript = '"' + options.shellScript.replace(/\\/g, '\\\\') + '"';
    --- End diff --
    
    Looks like it was overwritten incorrectly. Updated the pull request with the replacing
of " as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message