cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblood <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser issue #215: CB-12560: (android) fix null pointer...
Date Mon, 01 May 2017 23:38:26 GMT
Github user dblood commented on the issue:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/215
  
    I dug through the code quite a bit and think I have found why this was so hard to reproduce
for me.  (restoring the version I had in my repo instantly caused the problem though).
    
    I was initially using cordova-plugin-inappbrowser 1.1.1.  
    In version 1.2.1 (specifically 4d9e4884) the 'sendUpdate(obj, false);' was moved into
a 'runOnUiThread' Runnable which ensures that they are run serially, and on the same thread.
    
    Although this 'fixed' the common NullPointerException when close() was called twice the
sendUpdate function still wasn't correctly guarded, only the single instance of when sendUpdate
was being called with 'false'.
    
    This pull request 'fixes' contextCallback references used within the same function to
ensure another thread can't modify the locally scoped reference during function execution.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message