Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: ferretdayo <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
Message-ID: <git-pr-264-cordova-plugin-camera@git.apache.org>
Subject: [GitHub] cordova-plugin-camera pull request #264: change CameraOptions of README.md f...
Content-Type: text/plain
Date: Sat, 29 Apr 2017 04:56:38 +0000 (UTC)
archived-at: Sat, 29 Apr 2017 04:56:41 -0000

GitHub user ferretdayo opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/264

    change CameraOptions of README.md for in ios

    ### Platforms affected
    iOS
    
    ### What does this PR do?
    it modified on README.md.
    it may be wrong.
    
    In README.md
     - `allowEdit` is `true` on default in CameraOptions.
    
    but, actually `allowEdit` default value is `false`.
    In a part of `www/Camera.js`
    ```
    cameraExport.getPicture = function(successCallback, errorCallback, options) {
        options = options || {};
    
        var allowEdit = !!options.allowEdit;    // if do not set value, this allowEdit is false
    };
    ```
    
    ### What testing has been done on this change?
    
    ### Checklist
    - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ferretdayo/cordova-plugin-camera fix/CameraOptions-doc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/264.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #264
    
----
commit 4c69322106115d72ffc8db40ecb896d94afda802
Author: ferretdayo <ferretdayo@hotmail.co.jp>
Date:   2017-04-29T04:34:46Z

    modified init value

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org