Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: stevengill <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-549-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-549-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request #549: CB-12705: Pass plugin info to project-level p...
Content-Type: text/plain
Message-Id: <20170426232958.A7ACFDFDAC@git1-us-west.apache.org>
Date: Wed, 26 Apr 2017 23:29:58 +0000 (UTC)
archived-at: Wed, 26 Apr 2017 23:30:00 -0000

Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/549#discussion_r113586243
  
    --- Diff: cordova-lib/src/hooks/HooksRunner.js ---
    @@ -178,7 +178,9 @@ function runScriptViaModuleLoader(script, context) {
         }
         var scriptFn = require(script.fullPath);
         context.scriptLocation = script.fullPath;
    -    context.opts.plugin = script.plugin;
    +    if(script.plugin) {
    +        context.opts.plugin = script.plugin;
    --- End diff --
    
    Am I correct in understanding that this is already being passed in? You just add a if statement to confirm it exists before assigning?
    
    @feichngr 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org