cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From audreyso <...@git.apache.org>
Subject [GitHub] cordova-lib pull request #537: CB-11908: Add tests for edit-config in config...
Date Wed, 05 Apr 2017 22:44:21 GMT
GitHub user audreyso opened a pull request:

    https://github.com/apache/cordova-lib/pull/537

    CB-11908: Add tests for edit-config in config.xml, fix typo, and rebased.

    Add one more test case
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    
    ### What does this PR do?
    Rebased CB-11908 (add tests for edit-config in config.xml and fix typo).
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/audreyso/cordova-lib rebaseCB-11908

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/537.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #537
    
----
commit 116f06f2090342c9914cd9ec3a1b17d422d8ffbf
Author: ktop <ktop500@gmail.com>
Date:   2016-12-09T19:53:50Z

    CB-11908 Add tests for edit-config in config.xml and fix typo
    
    Add one more test case

commit a50bbebf416ffb0c3813f7d4bdec1f1c1861bf9c
Author: Audrey So <audreyso@apache.org>
Date:   2017-04-05T22:11:10Z

    CB-11908 : updated tests to use jasmine 2.0

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message