cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From filmaj <...@git.apache.org>
Subject [GitHub] cordova-plugin-vibration pull request #53: CB-12695: fix jshint / double-var...
Date Mon, 24 Apr 2017 23:58:51 GMT
GitHub user filmaj opened a pull request:

    https://github.com/apache/cordova-plugin-vibration/pull/53

    CB-12695: fix jshint / double-varing

    ### Platforms affected
    
    All - JS
    
    ### What does this PR do?
    
    Fixes `npm test` failure due to double-definition of `pattern` variable.
    
    ### What testing has been done on this change?
    
    Just `npm test`. Ideally should wait for the CI qa-bot to respond before merging.
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database: [CB-12695](https://issues.apache.org/jira/browse/CB-12695)
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/cordova-plugin-vibration jshint-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-vibration/pull/53.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #53
    
----
commit 168204b2eb9e91eb8beb08b560cc87c048ab1a74
Author: filmaj <maj.fil@gmail.com>
Date:   2017-04-24T23:52:35Z

    CB-12695: fix jshint / double-varing

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message