cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From filmaj <...@git.apache.org>
Subject [GitHub] cordova-android pull request #373: Support for SDK Tools v26, simplified tar...
Date Thu, 06 Apr 2017 21:16:15 GMT
GitHub user filmaj opened a pull request:

    https://github.com/apache/cordova-android/pull/373

    Support for SDK Tools v26, simplified target parsing and preference for using newer `sdkmanager`
and `avdmanager` commands

    Please review and test @infil00p, @dpogue, @shazron.
    
    ### Platforms affected
    
    Android
    
    ### What does this PR do?
    
    - Adds support for SDK Tools v26.
    - For android target parsing, now prioritizes using `avdmanager` over `android`. Also
ensures that, when using `android`, to always use the singular form of the command (`android
list target`), as the plural form got silently removed by Google.
    - For AVD parsing, now prioritizes using `avdmanager` over `android`. Also ensures that,
when using `android`, to always use the singular form of the command (`android list avd`),
as the plural form got silently removed by Google.
    
    ### What testing has been done on this change?
    
    Updated specs, also tested the following scenario:
    ```
    $ ./bin/create ../myproj
    $ cd ../myproj
    $ ./cordova/run --emulate
    ```
    .. on the following platforms:
    - Mac OS 10.12 with Android SDK Tools v26.
    - Windows 10 with Android SDK Tools v25.3.1.
    - Windows 10 with Android SDK Tools v26.
    
    Worked for me.
    
    ### Checklist
    - [x] Issue filed: [CB-12640](https://issues.apache.org/jira/browse/CB-12640)
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/filmaj/cordova-android CB-12640

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/373.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #373
    
----
commit f8e4f92970d1f262baf607210febd448278b28c6
Author: filmaj <maj.fil@gmail.com>
Date:   2017-04-06T20:13:38Z

    CB-12640: support for android sdk tools 26.0.1. simplified target parsing by using avdmanager
instead of sdkmanager. flipped target parsing logic so that it always tries to use avdmanager
to retrieve targets first, then falls back to android command if avdmanager cannot be found
(and errors with ENOENT). updated tests.

commit 4995b89025b9802f1f7f5417df2e152794fd6ff5
Author: filmaj <maj.fil@gmail.com>
Date:   2017-04-06T20:48:58Z

    CB-12640: flipped avd parsing logic so that it always tries to use avdmanager to retrieve
avds first, then falls back to android command if avdmanager cannot be found (and errors with
ENOENT). updated tests - and added explicit tests to ensure to shell out to singular forms
of sub-commands when executing `android`

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message