cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-ios pull request #310: CB-12009 - <resource-file> target attribute i...
Date Fri, 21 Apr 2017 23:00:39 GMT
GitHub user shazron opened a pull request:

    https://github.com/apache/cordova-ios/pull/310

    CB-12009 - <resource-file> target attribute ignored on iOS when installing a Cordova
plugin

    ### Platforms affected
    
    self
    
    ### What does this PR do?
    
    Fix bug where <resource-file> `target` attribute in plugin.xml was being ignored.
    
    ### What testing has been done on this change?
    
    npm test, local adding of plugin with target attribute
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shazron/cordova-ios CB-12009

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/310.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #310
    
----
commit a6d21d7b3693f8c573fa5b16f0424ee57473abb0
Author: Shazron Abdullah <shazron@gmail.com>
Date:   2017-04-21T22:47:53Z

    CB-12009 - <resource-file> target attribute ignored on iOS when installing a Cordova
plugin

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message