cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kerrishotts <...@git.apache.org>
Subject [GitHub] cordova-ios pull request #302: CB-11895: openURL: is deprecated on iOS 10
Date Thu, 13 Apr 2017 01:05:45 GMT
GitHub user kerrishotts opened a pull request:

    https://github.com/apache/cordova-ios/pull/302

    CB-11895: openURL: is deprecated on iOS 10

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    - iOS
    
    ### What does this PR do?
    
    Addresses deprecation of openURL: in iOS 10 by using openURL:options:completionHandler:
instead.
    
    ### What testing has been done on this change?
    
    - CI Testing OK
    - Tested in sim on 10.3 and 9.3 & verified appropriate methods were called
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.
        - not applicable to this change


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kerrishotts/cordova-ios CB-11895

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/302.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #302
    
----
commit 7e9a22efcdcd085b68970dca61156e6995586e25
Author: Kerri Shotts <kerrishotts@gmail.com>
Date:   2017-04-12T21:02:57Z

    CB-11895: openURL: is deprecated on iOS 10

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message