cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-browser pull request #28: CB-12527
Date Thu, 13 Apr 2017 06:37:37 GMT
GitHub user purplecabbage opened a pull request:

    https://github.com/apache/cordova-browser/pull/28

    CB-12527

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    Browser
    
    ### What does this PR do?
    Adds platformAPI, and removes need for polyfil
    
    ### What testing has been done on this change?
    some
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/purplecabbage/cordova-browser CB-12527

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-browser/pull/28.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #28
    
----
commit f1b136d0958d2f85ea4c88f10ab7f757e5363e6c
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Date:   2017-04-07T06:51:12Z

    don't exit and don't expect a done()

commit 44578d2f9399dd614b270ce98ce00ed7db4d137c
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Date:   2017-04-07T21:59:52Z

    added some basic tests, and updated package with Jasmine@2.5.3

commit 3b4a52f69132eeb384c3320755112575aadbe875
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Date:   2017-04-13T05:57:40Z

    large refactor, added PlatformApi, deleted icons

commit 6281ea5af1a2c99a0fdc12356b01c36abc33c720
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Date:   2017-04-13T06:34:46Z

    hooking up run

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message