cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ferretdayo <>
Subject [GitHub] cordova-plugin-camera pull request #264: change CameraOptions of f...
Date Sat, 29 Apr 2017 04:56:38 GMT
GitHub user ferretdayo opened a pull request:

    change CameraOptions of for in ios

    ### Platforms affected
    ### What does this PR do?
    it modified on
    it may be wrong.
     - `allowEdit` is `true` on default in CameraOptions.
    but, actually `allowEdit` default value is `false`.
    In a part of `www/Camera.js`
    cameraExport.getPicture = function(successCallback, errorCallback, options) {
        options = options || {};
        var allowEdit = !!options.allowEdit;    // if do not set value, this allowEdit is
    ### What testing has been done on this change?
    ### Checklist
    - [ ] [Reported an issue]( in the JIRA
    - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull fix/CameraOptions-doc

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #264
commit 4c69322106115d72ffc8db40ecb896d94afda802
Author: ferretdayo <>
Date:   2017-04-29T04:34:46Z

    modified init value


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message