cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stalniy <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request #262: fix(error): changes error message f...
Date Fri, 21 Apr 2017 12:38:30 GMT
GitHub user stalniy opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/262

    fix(error): changes error message for ios in case if user cancel

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    iOS, Android
    
    ### What does this PR do?
    changes cancel error message for iOS and Android to be consistent between these 2 platforms
    
    ### What testing has been done on this change?
    opened Camera plugin on iOS and checked that error is correct in case when user cancel
camera modal window
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change. **Dont think it worth
spending to do automation testing here but glad to add if you will point me where I can do
this**


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stalniy/cordova-plugin-camera fix/cancel-consistency

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/262.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #262
    
----
commit 2bd0bedfb5ae3e8df935cc6b218f70c7a85cfed3
Author: Sergii Stotskyi <sergii.stotskyi@concreteplatform.com>
Date:   2017-04-21T11:08:37Z

    CB-12682: (ios, android): changes cancel error message to be consistent for ios android

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message