cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From filmaj <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request #218: CB-12266: (browser platform) ...
Date Tue, 25 Apr 2017 23:21:41 GMT
GitHub user filmaj opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/218

    CB-12266: (browser platform) loadstop event.url is now a string

    … instead of an object, aligning it with the other platforms.
    
    ### Platforms affected
    
    Browser.
    
    ### What does this PR do?
    
    Fixes [CB-12266](https://issues.apache.org/jira/browse/CB-12266): previously in the browser
platform, `loadstop` event object's `url` property would be an object and not a string, like
the other platforms.
    
    ### What testing has been done on this change?
    
    Tested in Chrome on a Mac desktop.
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database: [CB-12266](https://issues.apache.org/jira/browse/CB-12266)
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/filmaj/cordova-plugin-inappbrowser CB-12266

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/218.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #218
    
----
commit bfb33988be6dae6708a254872da3bf4081eeeb7b
Author: filmaj <maj.fil@gmail.com>
Date:   2017-04-25T23:19:48Z

    CB-12266: (browser platform) loadstop event.url is now a string instead of an object,
aligning it with the other platforms.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message