cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lazza <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request #125: CB-12626: (android) Fix crash...
Date Sun, 02 Apr 2017 14:29:30 GMT
GitHub user Lazza opened a pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/125

    CB-12626: (android) Fix crash on Samsung devices and splash screen not showing on some
other devices

    ### Platforms affected
    
    Android, all versions.
    
    ### What does this PR do?
    
    This PR drops the strategy of relying on the app preferences to store the `drawableId`
for the splash screen. This approach causes crashes on Samsung devices and prevents the splash
screen from working correctly on some other devices.
    
    ### What testing has been done on this change?
    
    This change has been tested on all devices reported in the JIRA issue:
    
    - Samsung Galaxy 7 Edge, Android 7.0
    - Samsung Galaxy Note 4, Android 6.0.1
    - Lenovo/Zuk Z1, Android 5.1.1
    - Official Android Emulator with Nexus S simulated hardware, API 25
    
    ### Checklist
    
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA
database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file
paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [x] Added automated test coverage as appropriate for this change.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Lazza/cordova-plugin-splashscreen master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-splashscreen/pull/125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #125
    
----
commit f94a2c27e5c1082c8b73949e3bf18d0ec4609f9e
Author: Andrea Lazzarotto <andrea.lazzarotto@gmail.com>
Date:   2017-03-15T12:03:00Z

    Samsung crash quick-n-dirty fix

commit f6aab146a45e172151fe931436534ba143238ec5
Author: Andrea Lazzarotto <andrea.lazzarotto@gmail.com>
Date:   2017-04-01T13:22:23Z

    Updated Android plugin
    
    Prefer a slightly slower, but bulletproof, way to check for the splashscreen instead of
relying on the Cordova preferences. This fixes the splash screen on several phones.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message