cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From filmaj <...@git.apache.org>
Subject [GitHub] cordova-plugin-geolocation issue #87: Update CDVLocation.m
Date Wed, 26 Apr 2017 22:20:22 GMT
Github user filmaj commented on the issue:

    https://github.com/apache/cordova-plugin-geolocation/pull/87
  
    Okay, with that sample code of using the watch, I am able to reproduce one warning of
this on an iPhone 5S running iOS 10.2:
    
    ```
    2017-04-26 17:14:37.015628 HelloCordova[273:48525] THREAD WARNING: ['Geolocation'] took
'44.689941' ms. Plugin should use a background thread.
    ```
    
    I need to run the app from xcode to see that warning, though - that warning does not show
in the Device Console.
    
    Now when using @avishekcode's patch, the warning is gone.
    
    So I'm fine with merging this patch in as long as any comments from @shazron are addressed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message