cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblood <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser issue #215: CB-12560: (android) fix null pointer...
Date Wed, 26 Apr 2017 05:48:43 GMT
Github user dblood commented on the issue:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/215
  
    Of course.  I will work on a test script.  The library I was using is https://github.com/IdentityModel/oidc-client-js
    with type of "id_token token" and monitoring on.  This would attempt to request a "token/userinfo"
endpoint on the server once a second regardless of if the previous request had completed.
 This allowed the completion handler of both requests to be executed concurrently.
    
    A bit of background for why I didn't do an automated test:  
    1) Although this issue consistently occurred sometime within 300 seconds for me, that
is 300 potential requests (or possibly non) that would fail based on my local environment
and servers.
    2) Though it would prove a null pointer could happen with the old code, a negative test
for an exception is already handled by every other test (if the app didn't crash, there wasn't
a null pointer).  This could be applied to every method everywhere, with every type of runtime
exception, and adds no value.
    3) I didn't want to address the bigger issue, and the risk around the handling of cancelling
an in-progress request or if the response has completed but the callback hasn't completed
yet.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message