cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hollyschinsky <...@git.apache.org>
Subject [GitHub] cordova-plugin-statusbar issue #78: CB-11858: (android) Add StatusBarStyle f...
Date Tue, 25 Apr 2017 17:09:35 GMT
Github user hollyschinsky commented on the issue:

    https://github.com/apache/cordova-plugin-statusbar/pull/78
  
    @filmaj @urmx @tobiasviehweger It's a bit confusing with iOS because the status bar styling
has changed several times and the `blacktranslucent` and `blackopaque` were deprecated in
iOS7. 
    
    My blog post was correct at the time but since the deprecation, the code in the StatusBar
plugin has been updated. If you look at these methods now, those two deprecated styles are
[only specifically applied when the version is pre 7](https://github.com/apache/cordova-plugin-statusbar/blob/master/src/ios/CDVStatusBar.m#L311-329).
Otherwise that code will set it to the `UIStatusBarStyleLightContent` style - which is light
foreground color (white text). This is the recommended setting [based on the apple docs](https://developer.apple.com/reference/uikit/uistatusbarstyle?language=objc)
for those deprecated values. 
    
    Also, make note that the `lightcontent` style preference is [automatically added to the
platform config.xml](https://github.com/apache/cordova-plugin-statusbar/blob/master/plugin.xml#L59-L66)
when you add the StatusBar plugin for iOS. So unless the developer specifically sets something
else for that it in the root project config.xml, that is going to be what is set by default
(not to be confused with the `default` style setting itself which is the opposite and dark
foreground color (black text) for light backgrounds :/). 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message