cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-plugin-media-capture issue #76: Audio Capture - added support for iP...
Date Tue, 25 Apr 2017 00:22:10 GMT
Github user purplecabbage commented on the issue:

    https://github.com/apache/cordova-plugin-media-capture/pull/76
  
    they are both device specific, and cordova specific
    I see these as something that an app developer should be providing themselves, unfortunately
there is not an API for this, or a demo/doc of how a developer would do it.
    
    The images already exist for every other device shape and size, so this isn't a new thing,
just covering more new devices.
    
    That said, I have never really agreed with the direction of providing a generic UI inside
this plugin, ...
    But, It is probably better to just accept this pr, and move on with another implementation
some day when we find the time.  
    
    The fact that @momomatteo ;) has taken the time to send this pr should speak much louder
than my personal feelings on the subject ... 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message