cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-android issue #321: CB-8978 Prepare copy resource-files from config....
Date Tue, 18 Apr 2017 21:17:27 GMT
Github user shazron commented on the issue:

    https://github.com/apache/cordova-android/pull/321
  
    Leaving some notes here for future reference (in case there are bugs):
    1. Firstly `cleanFileResources` is called, but effectively useless during runtime, even
if you have a `<resource-file>` tag in config.xml since prepare does not send a project
config (see my line comments above and https://github.com/apache/cordova-android/blob/dbce4de5b6313b8f10db64166612a8bcb56d898b/bin/templates/cordova/lib/prepare.js#L59)
    2. Because of item 1 above, this part of the feature cannot be tested
    3. No platform unit tests for this feature, which is important because of item 2 above
(no effective test available)
    4. The corresponding iOS implementation of this feature (https://issues.apache.org/jira/browse/CB-8980
and https://github.com/apache/cordova-ios/pull/305) has an example of unit tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message