cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kerrishotts <...@git.apache.org>
Subject [GitHub] cordova-ios pull request #302: CB-11895: openURL: is deprecated on iOS 10
Date Thu, 13 Apr 2017 01:38:04 GMT
Github user kerrishotts commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/302#discussion_r111295873
  
    --- Diff: CordovaLib/Classes/Private/Plugins/CDVIntentAndNavigationFilter/CDVIntentAndNavigationFilter.m
---
    @@ -115,11 +115,18 @@ + (BOOL)shouldOverrideLoadWithRequest:(NSURLRequest*)request navigationType:(UIW
             case CDVIntentAndNavigationFilterValueNavigationAllowed:
                 return YES;
             case CDVIntentAndNavigationFilterValueIntentAllowed:
    -            // only allow-intent if it's a UIWebViewNavigationTypeLinkClicked (anchor
tag) OR
    -            // it's a UIWebViewNavigationTypeOther, and it's an internal link
    -            if ([[self class] shouldOpenURLRequest:request navigationType:navigationType]){
    --- End diff --
    
    Whoops; trigger-happy `dd`, apparently. Fixing up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message