cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <>
Subject [GitHub] cordova-lib pull request #536: CB-12592 : Refactor and add delete
Date Tue, 04 Apr 2017 19:46:41 GMT
Github user stevengill commented on a diff in the pull request:
    --- Diff: cordova-lib/src/cordova/platform.js ---
    @@ -154,8 +154,9 @@ function addHelper(cmd, hooksRunner, projectRoot, targets, opts) {
                     return downloadPlatform(projectRoot, platform, spec, opts);
                 }).then(function(platDetails) {
                     if(fs.existsSync(path.join(projectRoot, 'package.json'))) {
    -                    delete require.cache[require.resolve(path.join(projectRoot, 'package.json'))];
    +                    pkgJson = cordova_util.requireNoCache(path.join(projectRoot, 'package.json'));
    --- End diff --
    I think this line + if statement can be deleted too

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message