cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From audreyso <>
Subject [GitHub] cordova-lib pull request #536: CB-12592 : Refactor and add delete
Date Mon, 03 Apr 2017 21:47:35 GMT
Github user audreyso commented on a diff in the pull request:
    --- Diff: cordova-lib/src/cordova/metadata/ubuntu_parser.js ---
    @@ -109,8 +110,8 @@ ubuntu_parser.prototype.update_manifest = function() {
             content += '\nIcon=qmlscene';
             console.warn('missing icon element in config.xml');
    -    fs.writeFileSync(path.join(this.path, 'manifest.json'), JSON.stringify(manifest));
    -    fs.writeFileSync(path.join(this.path, 'cordova.desktop'), content);
    --- End diff --
    Would you replace this with or just in cases when JSON.stringify is

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message